Overview: dim the background with the dim-factor property

Doing this rather than overdrawing a black rectangle saves us
(pixels in screen) * 8 bytes of memory bandwidth for every frame we draw going
into the overview.

It also allows us to dim the background on non-primary monitors making the
overall overview appearance consistent across all monitors.

https://bugzilla.gnome.org/show_bug.cgi?id=656433

diff --git a/data/theme/gnome-shell.css b/data/theme/gnome-shell.css
index 070d082c83e13dbef796f3e75ec1891c842eb058..110a6c3332b39b8f9bf04505498f3fe17e30d22b 100644 (file)
--- a/data/theme/gnome-shell.css
+++ b/data/theme/gnome-shell.css
@@ -396,7 +396,6 @@ StTooltip StLabel {
 
 #overview {
     spacing: 12px;
-    background-color: rgba(0,0,0,0.6);
 }
 
 .window-caption {

diff --git a/js/ui/overview.js b/js/ui/overview.js
index 4ecc378d8e677c943f65919ea97963735ea249a7..9da431a13bf1a2e15bfc2c5fad1150736eed20b4 100644 (file)
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -603,6 +603,12 @@ Overview.prototype = {
                            onCompleteScope: this
                          });
 
+        Tweener.addTween(this._background,
+                         { dim_factor: 0.4,
+                           time: ANIMATION_TIME,
+                           transition: 'easeOutQuad'
+                         });
+
         this._coverPane.raise_top();
         this._coverPane.show();
         this.emit('showing');
@@ -733,6 +739,12 @@ Overview.prototype = {
                            onCompleteScope: this
                          });
 
+        Tweener.addTween(this._background,
+                         { dim_factor: 1.0,
+                           time: ANIMATION_TIME,
+                           transition: 'easeOutQuad'
+                         });
+
         this._coverPane.raise_top();
         this._coverPane.show();
         this.emit('hiding');